Add support for Cloudflare Workers and Bun #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adams85
force-pushed
the
cfworker
branch
2 times, most recently
from
02657a1
to
8e0973f
Compare
adams85
changed the title
adams85
force-pushed
the
cfworker
branch
5 times, most recently
from
803d234
to
8d7a351
Compare
laliconfigcat
requested changes
Nov 21, 2024
README.md
Outdated
| replace the old package with the new and adjust the import specifiers (as shown [here](#1-install-and-import-package)). | ||
|
|
||
| > [!CAUTION] | ||
| > Please note that the SDK is still under development and is currently in beta phase. You use it at your own risk. |
There was a problem hiding this comment.
The "You use it at your own risk." part maybe not necessary, it sounds a bit harsh to me.
There was a problem hiding this comment.
I think this disclaimer is needed here until we go GA. It should be "Use it at your own risk." though. With "you" it's harsh indeed. :)
| async fetch(request, env, ctx): Promise<Response> { | ||
| // Creating the ConfigCat client instance using the SDK Key | ||
| const client = getClient( | ||
| "PKDVCLf-Hq-h-kCzMp-L7Q/HhOWfwVtZ0mb30i9wi17GQ", |
There was a problem hiding this comment.
maybe we should go with a V2 config here (and everywhere else)
laliconfigcat
approved these changes
Nov 21, 2024
adams85
force-pushed
the
cfworker
branch
5 times, most recently
from
0faa640
to
6fbefa3
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
Adds experimental support for Cloudflare Workers and Bun.
Breaking changes:
proxyfrom common client options (IOptions) and make it available on the Node platform only. (Very low impact expected as proxy hasn't been supported on any other platform than Node so far.)Requirement checklist (only if applicable)