Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config V2 #41

Merged
merged 31 commits into from
Mar 13, 2024
Merged

Config V2 #41

merged 31 commits into from
Mar 13, 2024

Conversation

laliconfigcat
Copy link
Member

@laliconfigcat laliconfigcat commented Feb 12, 2024

Describe the purpose of your pull request

Adding support to Config V2

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: Patch coverage is 84.74074% with 103 lines in your changes are missing coverage. Please review.

Project coverage is 73.71%. Comparing base (55f58ae) to head (3c94b89).

❗ Current head 3c94b89 differs from pull request most recent head a3a4856. Consider uploading reports for the commit a3a4856 to get more accurate results

Files Patch % Lines
internal/configcat/setting_value_v2_resource.go 86.11% 57 Missing and 31 partials ⚠️
...ternal/configcat/client/client_setting_value_v2.go 0.00% 12 Missing ⚠️
internal/configcat/config_resource.go 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   71.45%   73.71%   +2.25%     
==========================================
  Files          31       33       +2     
  Lines        3013     3686     +673     
==========================================
+ Hits         2153     2717     +564     
- Misses        689      766      +77     
- Partials      171      203      +32     
Flag Coverage Δ
unittests 73.71% <84.74%> (+2.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laliconfigcat laliconfigcat marked this pull request as ready for review February 13, 2024 13:47
@laliconfigcat laliconfigcat requested a review from a team as a code owner February 13, 2024 13:47
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@laliconfigcat laliconfigcat merged commit b114f97 into main Mar 13, 2024
1 of 3 checks passed
@laliconfigcat laliconfigcat deleted the v2 branch March 13, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants