Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI upload schemas #228

Merged
merged 12 commits into from
Oct 16, 2021
Merged

CI upload schemas #228

merged 12 commits into from
Oct 16, 2021

Conversation

maurolacy
Copy link
Contributor

Closes #186.

@maurolacy maurolacy marked this pull request as ready for review October 15, 2021 19:22
@maurolacy maurolacy changed the title Ci upload schemas CI upload schemas Oct 15, 2021
ethanfrey
ethanfrey reviewed Oct 15, 2021
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
ethanfrey
ethanfrey approved these changes Oct 16, 2021
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice delta. bye bye old artifacts

.gitignore
@@ -1,3 +1,5 @@
target
artifacts
.idea
packages/*/schema
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ethanfrey ethanfrey merged commit 120eb62 into main Oct 16, 2021
@ethanfrey ethanfrey deleted the ci-upload-schemas branch October 16, 2021 13:51
@ueco-jb ueco-jb mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

@hashedone hashedone Awaiting requested review from hashedone

@ueco-jb ueco-jb Awaiting requested review from ueco-jb

@uint uint Awaiting requested review from uint

@webmaster128 webmaster128 Awaiting requested review from webmaster128

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate schema automatically
2 participants
@maurolacy @ethanfrey