Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version PoE module #52

Merged
merged 5 commits into from
Jun 16, 2021
Merged

Initial version PoE module #52

merged 5 commits into from
Jun 16, 2021

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jun 10, 2021

Proof of Engagement (PoE)

This module contains the Proof of Engagement (PoE) contracts and integration points. See
the Whitepaper for more details about PoE.

This module provides first class support for PoE:

  • Bootstrap and contract instantiation
  • Query and CLI support
  • Genesis import/ export
  • Integration tests

Contracts

  • tg4-group - engagement group with weighted
    members
  • tg4-stake - validator group weighted by
    staked amount
  • valset - privileged contract to map a
    trusted cw4 contract to the Tendermint validator set running the chain
  • mixer - calculates the combined value of
    stake and engagement points. Source for the valset contract.

Command line interface (CLI)

  • Commands
  tgrade tx poe -h
  • Query
  tgrade query poe -h

Reviewer

Please see #53

@alpe alpe mentioned this pull request Jun 10, 2021
@ethanfrey
Copy link
Contributor

Cool. Looking forward to review.

@alpe alpe marked this pull request as ready for review June 10, 2021 16:29
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got to x/poe/bootstrap, but submitting the first part of the review now

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left to do:

poe: bootstrap, cli, client
twasm: all

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, this x/poe/client code was copied from the sdk with minor changes, right?
It is sooo much more convoluted than your code. Let's clean it up a bit or at least make an issue to do so. I can barely follow the flow of the gentx logic

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally finished looking at changes to x/twasm.
Looks good.

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fixes.

Good to merge

@alpe alpe mentioned this pull request Jun 16, 2021
@alpe alpe merged commit 5b48409 into main Jun 16, 2021
@alpe alpe deleted the poe_module branch June 16, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants