-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version PoE module #52
Conversation
Cool. Looking forward to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got to x/poe/bootstrap
, but submitting the first part of the review now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left to do:
poe: bootstrap, cli, client
twasm: all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, this x/poe/client code was copied from the sdk with minor changes, right?
It is sooo much more convoluted than your code. Let's clean it up a bit or at least make an issue to do so. I can barely follow the flow of the gentx logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally finished looking at changes to x/twasm
.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the fixes.
Good to merge
Proof of Engagement (PoE)
This module contains the Proof of Engagement (PoE) contracts and integration points. See
the Whitepaper for more details about PoE.
This module provides first class support for PoE:
Contracts
members
staked amount
trusted cw4 contract to the Tendermint validator set running the chain
stake and engagement points. Source for the valset contract.
Command line interface (CLI)
Reviewer
Please see #53