Add timeout to integration test #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgagniere
approved these changes
Jan 3, 2023
@sgagniere It typically takes 3m to run, so I hope the occasional "bad" linux machine isn't more than 3x as slow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
What
We've seen a few flaky integration test failures on Linux, where all tests say "(unknown)" for their completion time. Since the integration tests appear to
gotestsumas a single test, it's possible that they're timing out (the total time in this example job is 239.9s, which is very close to 4m). Furthermore, thegosumtestsource code shows that "unknown" is returned if there's a timeout: https://github.com/gotestyourself/gotestsum/blob/10c2a47f9b99c8b49cbea60d12a6c76af0678d50/testjson/summary.go#L118. We started seeing this after downgrading to s1-prod-ubuntu20-04-amd64-1 which is a slower machine than we were using previously.