Port "KAFKA-1723; make the metrics name in new producer more standard; patched by Manikumar Reddy; reviewed by Jay Kreps and Jun Rao" to common-metrics. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; patched by Manikumar Reddy; reviewed by Jay Kreps and Jun Rao" to common-metrics.
|
Not sure if @nehanarkhede wants to review since you pulled this code into common or @junrao since you reviewed the KAFKA patch. Should be straightforward since it's a direct port, but the reformatting required moving a bunch of changes over manually so it could use a once-over before merging. |
|
Best if @junrao reviews since he also reviewed the open source patch and I haven't. |
| * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on | ||
| * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| */ |
There was a problem hiding this comment.
Will need to change the header.
There was a problem hiding this comment.
We have #1 filed for that since the rest of the files didn't have it changed. I think we're actually required to maintain the existing notice and then just layer ours on top.
|
The rest of the stuff looks good. |
ewencp
added a commit
that referenced
this pull request
Jan 23, 2015
Port "KAFKA-1723; make the metrics name in new producer more standard; patched by Manikumar Reddy; reviewed by Jay Kreps and Jun Rao" to common-metrics.
janjwerner-confluent
added a commit
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.