Feature: Added Qualified and Custom reference name strategy approaches for protobuf references (Schema Registry) #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature parity with java version. Added ability to use any custom ReferenceSubjectNameStrategy by implementing ICustomReferenceSubjectNameStrategy and assigning implemented instance to ProtobufSerializerConfig property CustomReferenceSubjectNameStrategy (Note: ReferenceSubjectNameStrategy enumeration value must be set to Custom) Code for ProtobufSerializer was reformatted
…ature parity with java version. Added ability to use any custom ReferenceSubjectNameStrategy by implementing ICustomReferenceSubjectNameStrategy and assigning implemented instance to ProtobufSerializerConfig property CustomReferenceSubjectNameStrategy (Note: ReferenceSubjectNameStrategy enumeration value must be set to Custom) Code for ProtobufSerializer was reformatted
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
@RobotechUSA , can you rebase to master? |
|
/sem-approve |
|
/sem-approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature allows producers to specify configuration for ReferenceSubjectNameStrategy the following enumeration values:
ReferenceName-> (default): Use the reference name as the subject name.Qualified-> Given a reference name, replace slashes with dots, and remove the .proto suffix to obtain the subject name. For example, mypackage/myfile.proto becomes mypackage.myfile. (This provides feature parity with java client)Custom-> Use a custom reference subject name strategy resolver to determine the subject name. This is done by implementing ICustomReferenceSubjectNameStrategy and assigning instance to ProtobufSerializerConfig property CustomReferenceSubjectNameStrategyBackground
An internal team is using java has implemented their Schema Registry with
QualifiedReferenceSubjectNameStrategy. As a dotnet team we need to interoperate with that work. Unfortunately, we cannot without this proposed change (We require feature parity with java). Further, we are not allowed to auto register schemas.Other Information