Add CreateTopic method to MockCluster
#1047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `CreateTopic` method to `MockCluster`. This allows the creation of topics without having to use a `Producer`.
|
|
jdemeyer
reviewed
Aug 29, 2023
kafka/mockcluster.go
Outdated
| @@ -92,6 +92,18 @@ func (mc *MockCluster) SetRoundtripDuration(brokerID int, duration time.Duration | |||
| return nil | |||
| } | |||
|
|
|||
| // CreateTopic creates a topic without having to use a producer | |||
| func (mc *MockCluster) CreateTopic(topic string, partitons, replicationFactor int) error { | |||
There was a problem hiding this comment.
fixed - thank you!
|
Thanks for this PR. Created internal branch and PR #1072 to run CI pipelines on this. |
|
Merged with #1072, added CHANGELOG and made sure it passes CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
CreateTopicmethod toMockCluster. This allows the creation of topics without having to use aProducer.