Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mock schema registry client does not return correct id from cache #971

Merged
merged 2 commits into from
Jul 24, 2023
Merged

fix: mock schema registry client does not return correct id from cache #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5d8398
fix: mock schema registry client does not return correct id from cache
srlk Mar 30, 2023
650140f
Update CHANGELOG.md
milindl Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# Confluent's Golang client for Apache Kafka

# v2.3.0

This is a maintenance release.

## Fixes

* Fixes a bug in the mock schema registry client where the wrong ID was being
returned for pre-registered schema (#971, @srlk).


# v2.2.0

Expand Down
2 changes: 1 addition & 1 deletion schemaregistry/mock_schemaregistry_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func (c *mockclient) Register(subject string, schema SchemaInfo, normalize bool)
}
c.schemaCacheLock.RUnlock()
if ok {
return id, nil
return idCacheEntryVal.id, nil
}

id, err = c.getIDFromRegistry(subject, schema)
Expand Down