Dev separate sr into workspace

.npmignore

@@ -5,6 +5,7 @@ deps/*
 .gitmodules
 Dockerfile
 deps/librdkafka/config.h
+schemaregistry
 build
 .github
 .vscode

eslint.config.js

@@ -54,7 +54,7 @@ module.exports = ts.config(
     },
     ...ts.configs.recommended.map((config) => ({
         ...config,
-        ignores: ["**/*.js"],
+        ignores: ["**/*.js", "types/rdkafka.d.ts", "types/kafkajs.d.ts", "types/config.d.ts"],
         rules: {
             ...config.rules,
             "prefer-const": "warn",

package.json

@@ -12,8 +12,7 @@
     "test": "make test",
     "install": "node-pre-gyp install --fallback-to-build",
     "prepack": "node ./ci/prepublish.js",
-    "test:types": "tsc -p .",
-    "test:schemaregistry": "make -f Makefile.schemaregistry test"
+    "test:types": "tsc -p ."
   },
   "binary": {
     "module_name": "confluent-kafka-javascript",
@@ -48,31 +47,14 @@
     "typescript-eslint": "^8.2.0"
   },
   "dependencies": {
-    "@aws-sdk/client-kms": "^3.637.0",
-    "@azure/identity": "^4.4.1",
-    "@azure/keyvault-keys": "^4.8.0",
-    "@bufbuild/protobuf": "^2.0.0",
-    "@criteria/json-schema": "^0.10.0",
-    "@criteria/json-schema-validation": "^0.10.0",
-    "@google-cloud/kms": "^4.5.0",
-    "@hackbg/miscreant-esm": "^0.3.2-patch.3",
     "@mapbox/node-pre-gyp": "^1.0.11",
-    "@smithy/types": "^3.3.0",
-    "@types/validator": "^13.12.0",
-    "ajv": "^8.17.1",
-    "async-mutex": "^0.5.0",
-    "avsc": "^5.7.7",
-    "axios": "^1.7.3",
     "bindings": "^1.3.1",
-    "json-stringify-deterministic": "^1.0.12",
-    "jsonata": "^2.0.5",
-    "lru-cache": "^11.0.0",
-    "nan": "^2.17.0",
-    "node-vault": "^0.10.2",
-    "ts-jest": "^29.2.4",
-    "validator": "^13.12.0"
+    "nan": "^2.17.0"
   },
   "engines": {
     "node": ">=18.0.0"
-  }
+  },
+  "workspaces": [
+    "schemaregistry"
+  ]
 }

Makefile.schemaregistry → schemaregistry/Makefile.schemaregistry

@@ -2,15 +2,15 @@
 
 # Variables
 NODE ?= node
-ESLINT ?= ./node_modules/.bin/eslint
-JEST ?= ./node_modules/.bin/jest
-TS_NODE ?= ./node_modules/.bin/ts-node
+ESLINT ?= ../node_modules/.bin/eslint
+JEST ?= ../node_modules/.bin/jest
+TS_NODE ?= ../node_modules/.bin/ts-node
 
 # Paths
-SRC_DIR = schemaregistry
-SR_TEST_DIR = test/schemaregistry
-DEK_TEST_DIR = test/schemaregistry/rules/encryption/dekregistry
-INTEG_DIR = e2e/schemaregistry
+SRC_DIR = .
+SR_TEST_DIR = ../test/schemaregistry
+DEK_TEST_DIR = ../test/schemaregistry/rules/encryption/dekregistry
+INTEG_DIR = ../e2e/schemaregistry
 
 # Tasks
 .PHONY: all lint test integtest

schemaregistry/jest.config.js

@@ -0,0 +1,6 @@
+module.exports = {
+    roots: [".."],
+    transform: {
+      '^.+\\.tsx?$': 'ts-jest',
+    },
+  };

schemaregistry/package.json

@@ -0,0 +1,59 @@
+{
+  "name": "@confluentinc/schemaregistry",
+  "version": "v0.1.16-devel",
+  "description": "Node.js client for Confluent Schema Registry",
+  "main": "lib/index.js",
+  "devDependencies": {
+    "@bufbuild/buf": "^1.37.0",
+    "@bufbuild/protoc-gen-es": "^2.0.0",
+    "@eslint/js": "^9.9.0",
+    "@types/eslint__js": "^8.42.3",
+    "@types/node": "^20.16.1",
+    "bluebird": "^3.5.3",
+    "eslint": "^8.57.0",
+    "eslint-plugin-jest": "^28.6.0",
+    "jest": "^29.7.0",
+    "jsdoc": "^4.0.2",
+    "mocha": "^10.7.0",
+    "node-gyp": "^9.3.1",
+    "ts-jest": "^29.2.4",
+    "typescript": "^5.5.4",
+    "typescript-eslint": "^8.2.0"
+  },
+  "dependencies": {
+    "@aws-sdk/client-kms": "^3.637.0",
+    "@azure/identity": "^4.4.1",
+    "@azure/keyvault-keys": "^4.8.0",
+    "@bufbuild/protobuf": "^2.0.0",
+    "@criteria/json-schema": "^0.10.0",
+    "@criteria/json-schema-validation": "^0.10.0",
+    "@google-cloud/kms": "^4.5.0",
+    "@hackbg/miscreant-esm": "^0.3.2-patch.3",
+    "@smithy/types": "^3.3.0",
+    "@types/validator": "^13.12.0",
+    "ajv": "^8.17.1",
+    "async-mutex": "^0.5.0",
+    "avsc": "^5.7.7",
+    "axios": "^1.7.3",
+    "json-stringify-deterministic": "^1.0.12",
+    "jsonata": "^2.0.5",
+    "lru-cache": "^11.0.0",
+    "node-vault": "^0.10.2",
+    "validator": "^13.12.0"
+  },
+  "scripts": {
+    "test:types": "tsc -p .",
+    "test:schemaregistry": "make -f Makefile.schemaregistry test"
+  },
+
+  "keywords": [
+    "schemaregistry",
+    "confluent"
+  ],
+  "repository": {
+    "type": "git",
+    "url": "git@github.com:confluentinc/confluent-kafka-javascript.git"
+  },
+
+  "license": "MIT"
+}

schemaregistry/tsconfig.json

@@ -0,0 +1,31 @@
+{
+  "compilerOptions": {
+    "baseUrl": ".",
+    "lib": [
+      "es2021", "dom"
+    ],
+    "module": "preserve",
+    "target": "es2021",
+    "strict": true,
+    "esModuleInterop": true,
+    "forceConsistentCasingInFileNames": true,
+    "moduleResolution": "bundler",
+    "allowUnusedLabels": false,
+    "allowUnreachableCode": false,
+    "noFallthroughCasesInSwitch": true,
+    "noImplicitOverride": true,
+    "noImplicitReturns": true,
+    "noPropertyAccessFromIndexSignature": true,
+    "noUnusedLocals": true,
+    "useUnknownInCatchVariables": true,
+    "types": ["../node_modules/@types/node"],
+    "typeRoots": ["."],
+    "noEmit": true,
+    "resolveJsonModule": true,
+    "skipLibCheck": true
+  },
+  "include": [
+    "**/*",
+    "../test/**/*"
+  ]
+}

tsconfig.json

@@ -1,32 +1,18 @@
 {
   "compilerOptions": {
+    "module": "commonjs",
+    "lib": ["es6"],
+    "noImplicitAny": true,
+    "noImplicitThis": true,
+    "strictNullChecks": true,
     "baseUrl": ".",
-    "lib": [
-      "es2021", "dom"
-    ],
-    "module": "preserve",
-    "target": "es2021",
-    "strict": true,
-    "esModuleInterop": true,
-    "forceConsistentCasingInFileNames": true,
-    "moduleResolution": "bundler",
-    "allowUnusedLabels": false,
-    "allowUnreachableCode": false,
-    "noFallthroughCasesInSwitch": true,
-    "noImplicitOverride": true,
-    "noImplicitReturns": true,
-    "noPropertyAccessFromIndexSignature": true,
-    "noUnusedLocals": true,
-    "useUnknownInCatchVariables": true,
-    "types": ["node_modules/@types/node"],
+    "types": ["./node_modules/@types/node"],
     "typeRoots": ["."],
     "noEmit": true,
-    "resolveJsonModule": true,
-    "skipLibCheck": true
+    "forceConsistentCasingInFileNames": true,
+    "strictFunctionTypes": true
   },
-  "include": [
-    "index.d.ts",
-    "schemaregistry/**/*",
-    "test/**/*"
+  "files": [
+    "index.d.ts"
   ]
 }