Skip to content

Commit

Permalink
Update changelog and handle review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jliunyu committed Jul 7, 2021
1 parent b192a06 commit cd83451
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 2 deletions.
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# Confluent's Python client for Apache Kafka

## v1.8.0

v1.8.0 is a maintenance release with the following fixes and enhancements:

### Enhancements

- Support rd_kafka_memberid() from python clients (#1154).

confluent-kafka-python is based on librdkafka v1.8.0, see the
[librdkafka release notes](https://github.com/edenhill/librdkafka/releases/tag/v1.8.0)
for a complete list of changes, enhancements, fixes and upgrade considerations.


## v1.7.0

v1.7.0 is a maintenance release with the following fixes and enhancements:
Expand Down
4 changes: 2 additions & 2 deletions src/confluent_kafka/src/Consumer.c
Original file line number Diff line number Diff line change
Expand Up @@ -993,10 +993,10 @@ static PyObject *Consumer_memberid (Handle *self, PyObject *args,
memberid = rd_kafka_memberid(self->rk);

if (!memberid)
return NULL;
Py_RETURN_NONE;

memberidobj = Py_BuildValue("s", memberid);
rd_kafka_mem_free(NULL, memberid);
rd_kafka_mem_free(self->rk, memberid);

return memberidobj;
}
Expand Down
2 changes: 2 additions & 0 deletions tests/integration/consumer/test_consumer_memberid.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ def test_consumer_memberid(kafka_cluster):
consumer = kafka_cluster.consumer(consumer_conf)

assert consumer is not None
assert len(consumer.memberid()) == 0
kafka_cluster.seed_topic(topic, value_source=[b'memberid'])

consumer.subscribe([topic])
msg = consumer.poll(10)
assert msg is not None
assert msg.value() == b'memberid'
assert len(consumer.memberid()) > 0
assert isinstance(consumer.memberid(), str) is True
consumer.close()

0 comments on commit cd83451

Please sign in to comment.