kafkatest, refactoring, and bug fixes #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used to run the Kafka client tests
| "\n" | ||
| ".. py:function:: on_commit(consumer, err, partitions)\n" | ||
| "\n" | ||
| " :param Consumer consumer: Consumer instance.\n" |
There was a problem hiding this comment.
I can't remember if passing the consumer instance as part of the callback came up before. I checked and we have it elsewhere. Is this valuable? Often in Python you just grab what you need via closure.
|
LGTM. Also validated unit and integration tests against current librdkafka master since we don't have automated testing here yet. |
Closed
Closed
ghost
mentioned this pull request
7 tasks
7 tasks
4 tasks
dtheodor
pushed a commit
to dtheodor/confluent-kafka-python
that referenced
this pull request
Sep 4, 2018
Initial Go client for API review
5 tasks
6 tasks
7 tasks
6 tasks
7 tasks
7 tasks
7 tasks
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@edenhill Just filing this so I can leave comments. We can always close this and push updates directly