Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced stale pull #785; add config bool return_record_name #1028

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Replaced stale pull #785; add config bool return_record_name #1028

merged 2 commits into from
Mar 10, 2021

Conversation

slominskir
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Feb 4, 2021

@confluentinc It looks like @slominskir just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@slominskir slominskir mentioned this pull request Feb 4, 2021
Closed
@slominskir slominskir force-pushed the return_record_name branch 3 times, most recently from 4ef0b43 to 60e607f Compare February 4, 2021 17:17
@edenhill edenhill added the serdes Avro, JSON, Protobof, Schema-registry label Mar 9, 2021
mhowlett
mhowlett approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@mhowlett mhowlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @slominskir

@mhowlett mhowlett merged commit 60049a8 into confluentinc:master Mar 10, 2021
@mhowlett
Copy link
Contributor

@slominskir - i'm thinking we really should have added a conf dict parameter, and made return.record.name a property in that. I'm thinking i'm probably going to break this, with justification being the new serde API is still technically marked as experimental. I'm in the process of finalizing this.

@slominskir
Copy link
Contributor Author

@mhowlett OK, that should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhowlett mhowlett mhowlett approved these changes

Assignees
No one assigned
Labels
serdes Avro, JSON, Protobof, Schema-registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slominskir @mhowlett @edenhill