-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACL operations #1286
ACL operations #1286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is great, fantastic work!
39e54a6
to
f725016
Compare
458bb3a
to
0f7cc50
Compare
Thanks Magnus, you spotted a lot of improvements! Most of them are solved, some have a question to answer. Let me now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, left some minor things that should be addressed.
48fc2ba
to
fbaab3f
Compare
50d7c87
to
ca11250
Compare
d1d2673
to
652f6db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of points, then good to go!
f5e22f2
to
ae2520b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
Let's not merge this until v1.9.0 has been released.
- create_acls - describe_acls - delete_acls
ae2520b
to
2cc398e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- create_acls - describe_acls - delete_acls
- create_acls - describe_acls - delete_acls
Python bindings for the CreateAcls, DescribeAcls and DeleteAcls operations.
needs the 1.9.0 version here
confluentinc/librdkafka#3741