Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL operations #1286

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Feb 22, 2022

Python bindings for the CreateAcls, DescribeAcls and DeleteAcls operations.

needs the 1.9.0 version here
confluentinc/librdkafka#3741

Copy link
Contributor

@edenhill edenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is great, fantastic work!

.travis.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
examples/adminapi.py Outdated Show resolved Hide resolved
examples/adminapi.py Outdated Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Outdated Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Outdated Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Show resolved Hide resolved
@emasab emasab requested a review from a team as a code owner March 23, 2022 18:39
@emasab emasab force-pushed the feature/acl-operations branch 3 times, most recently from 39e54a6 to f725016 Compare March 29, 2022 17:04
@CLAassistant
Copy link

CLAassistant commented Apr 1, 2022

CLA assistant check
All committers have signed the CLA.

@emasab emasab force-pushed the feature/acl-operations branch from 458bb3a to 0f7cc50 Compare April 1, 2022 16:47
@emasab
Copy link
Contributor Author

emasab commented Apr 1, 2022

Thanks Magnus, you spotted a lot of improvements! Most of them are solved, some have a question to answer. Let me now!

@emasab emasab requested review from edenhill and removed request for a team April 1, 2022 17:25
Copy link
Contributor

@edenhill edenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, left some minor things that should be addressed.

.travis.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Outdated Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Outdated Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Outdated Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Show resolved Hide resolved
src/confluent_kafka/src/confluent_kafka.h Outdated Show resolved Hide resolved
@emasab emasab force-pushed the feature/acl-operations branch 2 times, most recently from 48fc2ba to fbaab3f Compare May 19, 2022 10:17
@emasab emasab requested a review from edenhill May 19, 2022 10:21
@emasab emasab force-pushed the feature/acl-operations branch 4 times, most recently from 50d7c87 to ca11250 Compare May 25, 2022 18:04
@emasab emasab force-pushed the feature/acl-operations branch 2 times, most recently from d1d2673 to 652f6db Compare May 30, 2022 12:52
Copy link
Contributor

@edenhill edenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of points, then good to go!

examples/docker/Dockerfile.alpine Outdated Show resolved Hide resolved
src/confluent_kafka/src/confluent_kafka.h Outdated Show resolved Hide resolved
src/confluent_kafka/src/confluent_kafka.h Outdated Show resolved Hide resolved
@emasab emasab force-pushed the feature/acl-operations branch 2 times, most recently from f5e22f2 to ae2520b Compare May 31, 2022 11:56
@emasab emasab changed the base branch from master to v1.9.0rc May 31, 2022 11:57
@edenhill edenhill changed the title ACL operations [DO NOT MERGE UNTIL v1.10] ACL operations May 31, 2022
Copy link
Contributor

@edenhill edenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

Let's not merge this until v1.9.0 has been released.

- create_acls
- describe_acls
- delete_acls
@emasab emasab force-pushed the feature/acl-operations branch from ae2520b to 2cc398e Compare May 31, 2022 15:00
Copy link
Contributor

@edenhill edenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edenhill edenhill changed the title [DO NOT MERGE UNTIL v1.10] ACL operations ACL operations May 31, 2022
@emasab emasab merged commit c0cb24e into confluentinc:v1.9.0rc Jun 2, 2022
jliunyu pushed a commit that referenced this pull request Jun 14, 2022
- create_acls
- describe_acls
- delete_acls
jairhenrique pushed a commit to jairhenrique/confluent-kafka-python that referenced this pull request Jun 21, 2022
- create_acls
- describe_acls
- delete_acls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants