Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generic and specific avro examples #1381

Merged
merged 2 commits into from
Jul 1, 2022
Merged

generic and specific avro examples #1381

merged 2 commits into from
Jul 1, 2022

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Jun 30, 2022

moved protobuf to a similiar folder

@emasab
generic and specific avro examples
d410063 
moved protobuf to a similiar folder
@emasab emasab requested a review from a team as a code owner June 30, 2022 09:25
mhowlett
mhowlett approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@mhowlett mhowlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the empty examples/protobuf/__init__.py file necessary?

@emasab
Copy link
Contributor Author

emasab commented Jul 1, 2022

removed it since it's optional since Python 3.3

@emasab emasab merged commit d189075 into master Jul 1, 2022
@emasab emasab deleted the feature/examples-avro-generic-and-specific branch July 1, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhowlett mhowlett mhowlett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emasab @mhowlett