V1.9.2rc integration tests upgrade #1401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emasab
force-pushed
the
v1.9.2rc-integration-tests-upgrade
branch
from
2b1df96 to
929d28c
Compare
emasab
force-pushed
the
v1.9.2rc-integration-tests-upgrade
branch
from
929d28c to
5a94ded
Compare
it was using the SR instance without basic auth. Upgraded SR configuration properties.
changed imports from relative to absolute.
emasab
force-pushed
the
v1.9.2rc-integration-tests-upgrade
branch
from
5a94ded to
5ae1cc4
Compare
|
Tests output |
mhowlett
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-compose in newer version was using the .env file as its configuration file and cluster-up wasn't working
the test was using the wrong SR instance, the one without authentication
the old compiled py files were giving an error with the latest python protobuf. Recompiling them would give an import error with newer Python versions because of the relative import not explictlly declared. Changing them to absolute import is the way suggested by protobuf developers.