Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the pipeline after changes made by cc-service-bot #1458

Merged
merged 5 commits into from
Oct 28, 2022
Merged

Conversation

cchristous
Copy link
Member

@cchristous cchristous commented Oct 28, 2022

This fixes the pipeline so that it runs as expected again. In 6cd2e73#diff-f4c421dab68fb568a2a5f47b7851a85a409574b05f841f635bad1880b82db03bL6-L8, the service bot updated the pipeline to what it thought was the proper state. However, this was not correct. Instead, in #1457, I disabled the service bot management of the pipeline, so now it will not override manual changes/configuration of the pipeline.

Testing

The attached Semaphore workflow now runs properly: https://confluentinc.semaphoreci.com/workflows/45ba9357-0f6c-4907-ac24-859ccffc1126?pipeline_id=a7f31c43-2ee4-4abe-8644-c03964cbbf66

@cchristous cchristous marked this pull request as ready for review October 28, 2022 20:27
@cchristous cchristous requested a review from a team as a code owner October 28, 2022 20:27
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cchristous cchristous merged commit d16a199 into master Oct 28, 2022
@cchristous cchristous deleted the fix-pipeline branch October 28, 2022 20:31
@cchristous cchristous restored the fix-pipeline branch November 4, 2022 18:25
mahajanadhitya pushed a commit that referenced this pull request Feb 3, 2023
* Revert "chore: update repo semaphore config"

This reverts commit 6cd2e73.

* fix the pipeline after changes made by cc-service-bot
emasab pushed a commit that referenced this pull request Jun 19, 2023
* Revert "chore: update repo semaphore config"

This reverts commit 6cd2e73.

* fix the pipeline after changes made by cc-service-bot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants