JSON referenced schema support #1514
Conversation
anchitj
force-pushed
the
referencedJsonTest
branch
2 times, most recently
from
ea82e94 to
f50d5f6
Compare
anchitj
changed the title
anchitj
force-pushed
the
referencedJsonTest
branch
from
f50d5f6 to
e19e9d7
Compare
anchitj
force-pushed
the
referencedJsonTest
branch
2 times, most recently
from
fd856a8 to
2f01818
Compare
anchitj
force-pushed
the
referencedJsonTest
branch
from
2f01818 to
6f189ff
Compare
| if named_schemas is None: | ||
| named_schemas = {} | ||
| for ref in schema.references: | ||
| referenced_schema = schema_registry_client.get_version(ref.subject, ref.version) |
There was a problem hiding this comment.
Can we use a batch call for fetching the references?
There was a problem hiding this comment.
I checked on this, it doesn't looks like it's available directly through schema registry. https://docs.confluent.io/platform/current/schema-registry/develop/api.html#post--subjects-(string-%20subject)-versions
There was a problem hiding this comment.
In that case, can we parallelize the calls? Maybe in future.
| if named_schemas is None: | ||
| named_schemas = {} | ||
| for ref in schema.references: | ||
| referenced_schema = schema_registry_client.get_version(ref.subject, ref.version) |
There was a problem hiding this comment.
In that case, can we parallelize the calls? Maybe in future.
|
Fix build issues as well |
Added a unit test. I believe the existing tests should cover the added code. Please let me know if you want me to add some more specific tests. |
| raise ValueError( | ||
| """schema_registry_client must be provided if "schema_str" is a Schema instance with references""") | ||
| else: | ||
| raise ValueError('You must pass either str or Schema') |
| @@ -43,6 +43,34 @@ def __exit__(self, *args): | |||
| return False | |||
|
|
|||
|
|
|||
| def _id_of(schema): | |||
There was a problem hiding this comment.
This function is not needed anymore!
There was a problem hiding this comment.
Missed removing it. Updated now.
* JSON referenced schema support * Changes * PR Feedback * PR Feedback * PR Feedback * PR Feedback * Fix wrong documentation * PR Feedback * Update unit tests * PR Feedback * Use ref.name as the id * Remove _id_of function
Changes to support referenced schemas in JSON schema.
Referenced schemas are always assumed to be registered in the SR prior.