Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIP-320: Allow fetchers to detect #1540

Merged
merged 12 commits into from
Apr 5, 2023
Merged

KIP-320: Allow fetchers to detect #1540

merged 12 commits into from
Apr 5, 2023

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Mar 27, 2023

and handle log truncation. Python changes

@emasab emasab requested a review from a team as a code owner March 27, 2023 20:57
@emasab
KIP-320: Allow fetchers to detect
33610fa 
and handle log truncation. Python changes
philipnee
philipnee reviewed Mar 28, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@emasab emasab force-pushed the feature/kip-320 branch from afb6592 to 9083277 Compare April 4, 2023 15:21
@emasab emasab force-pushed the feature/kip-320 branch from d1656b0 to aed7c0f Compare April 4, 2023 16:38
pranavrth
pranavrth reviewed Apr 5, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
src/confluent_kafka/src/Consumer.c Show resolved Hide resolved
src/confluent_kafka/src/confluent_kafka.c Show resolved Hide resolved
src/confluent_kafka/src/confluent_kafka.c Show resolved Hide resolved
src/confluent_kafka/src/confluent_kafka.h Show resolved Hide resolved
src/confluent_kafka/src/Consumer.c Show resolved Hide resolved
@pranavrth
Copy link
Member

Update the docs as well for Message and TopicPartition.

milindl
milindl approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@milindl milindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from KIP-320 point of view, nothing seems wrong to me.

src/confluent_kafka/src/confluent_kafka.c Outdated Show resolved Hide resolved
@emasab emasab merged commit 8fbc981 into master Apr 5, 2023
@emasab emasab deleted the feature/kip-320 branch April 5, 2023 15:57
emasab added a commit that referenced this pull request Jun 19, 2023
@emasab
KIP-320: Allow fetchers to detect (#1540)
6a696bb 
and handle log truncation. Python changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavrth pranavrth pranavrth left review comments

@philipnee philipnee philipnee left review comments

@milindl milindl milindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emasab @pranavrth @philipnee @milindl