[KIP-554] User SCRAM credentials API #1575

mahajanadhitya · 2023-05-30T06:33:14Z

No description provided.

Solve some memory leaks Improve examples

in alterations, as in J,

user description. Add documentation.

pranavrth

Went through _scram.py file, examples folder and docs folder only. Going through other files.

examples/adminapi.py

src/confluent_kafka/admin/_scram.py

pranavrth · 2023-07-05T12:10:05Z

src/confluent_kafka/admin/_scram.py

+        self.scram_credential_infos = scram_credential_infos
+
+
+class UserScramCredentialAlteration:


We should mark this class as Abstract.

Subclassing ABC doesn't really make it non-instantiable if there isn't an abstract method.
It this case it should be more like a Kotlin sealed class, that cannot be subclassed outside the package,
but it's not possible in Python.

src/confluent_kafka/admin/_scram.py

examples/adminapi.py

src/confluent_kafka/admin/__init__.py

pranavrth

Ongoing C files review.

src/confluent_kafka/src/Admin.c

src/confluent_kafka/admin/__init__.py

pranavrth

Checking response

src/confluent_kafka/src/Admin.c

pranavrth

Check all the local variables in the Response parsing for Ref Count.
Don't nest multiple functions. create local variables for readability.

src/confluent_kafka/src/Admin.c

tests/test_Admin.py

tests/integration/admin/test_basic_operations.py

pranavrth

Almost there. Some nits. Nothing major.

CHANGELOG.md

examples/adminapi.py

src/confluent_kafka/admin/__init__.py

src/confluent_kafka/src/Admin.c

and exception message

related to PyDict_SetItemString

pranavrth

Great work Guys!.

LGTM! :)

mahajanadhitya added 17 commits May 18, 2023 12:34

Initial Changes

d4e28f3

Changes

3aca974

Changes

f59cc4d

Changes

d0facf2

Changes

814f19d

Changes

e7209a1

Changes

961e5a1

Changes

1fe51f9

changes

8b249f6

Changes

7b28acf

Changes

652feff

Changes

4fd0ebe

Changes

9a7717e

Changes

4420a74

Changes

8a8ba5f

Changes

fcc37ff

Changes

b69de54

mahajanadhitya requested a review from a team as a code owner May 30, 2023 06:33

mahajanadhitya and others added 8 commits May 30, 2023 12:30

flake changes

7478085

Reflect librdkafka changes

53673eb

Solve some memory leaks Improve examples

Move scram related classes to a private package

a38cf30

Reflect librdkafka changes about duplicate users

9cea327

in alterations, as in J,

Merge branch 'master' into feature/AdminClient-ScramAPI

cf70165

Update changelog

8b285e2

Fix memory leak

28d6c62

Return a different future for each

1a45a4f

user description. Add documentation.

emasab changed the title ~~Feature/admin client scram api~~ [KIP-554] User SCRAM credentials API Jul 4, 2023

Merge branch 'master' into feature/AdminClient-ScramAPI

77d46d9

pranavrth requested changes Jul 5, 2023

View reviewed changes

pranavrth requested changes Jul 6, 2023

View reviewed changes

src/confluent_kafka/src/Admin.c Outdated Show resolved Hide resolved

src/confluent_kafka/admin/__init__.py Outdated Show resolved Hide resolved

pranavrth requested changes Jul 6, 2023

View reviewed changes

tests/test_Admin.py Outdated Show resolved Hide resolved

tests/integration/admin/test_basic_operations.py Show resolved Hide resolved

Address comments

6604afb

pranavrth requested changes Jul 9, 2023

View reviewed changes

emasab and others added 6 commits July 10, 2023 11:55

Address comment about alteration index

5eac807

and exception message

Added more unit tests and fixed uninitialized value access

b851a01

Remove memory leaks

7e14f6a

related to PyDict_SetItemString

Move C array extractions to the event switch case

c9a27ec

Address remaining comments

3f08e00

Better naming for C variables

be33f70

pranavrth approved these changes Jul 10, 2023

View reviewed changes

emasab added 3 commits July 11, 2023 13:28

Merge branch 'master' into feature/AdminClient-ScramAPI

a9a69b2

Merge branch 'master' into feature/AdminClient-ScramAPI

d3207b0

Use make_futures_v2

33bcdc0

emasab merged commit 96d48e2 into master Jul 11, 2023

emasab deleted the feature/AdminClient-ScramAPI branch July 11, 2023 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[KIP-554] User SCRAM credentials API #1575

[KIP-554] User SCRAM credentials API #1575

mahajanadhitya commented May 30, 2023

pranavrth left a comment

pranavrth Jul 5, 2023

emasab Jul 7, 2023

pranavrth left a comment

pranavrth left a comment

pranavrth left a comment

pranavrth left a comment

pranavrth left a comment

		self.scram_credential_infos = scram_credential_infos


		class UserScramCredentialAlteration:

[KIP-554] User SCRAM credentials API #1575

[KIP-554] User SCRAM credentials API #1575

Conversation

mahajanadhitya commented May 30, 2023

pranavrth left a comment

Choose a reason for hiding this comment

pranavrth Jul 5, 2023

Choose a reason for hiding this comment

emasab Jul 7, 2023

Choose a reason for hiding this comment

pranavrth left a comment

Choose a reason for hiding this comment

pranavrth left a comment

Choose a reason for hiding this comment

pranavrth left a comment

Choose a reason for hiding this comment

pranavrth left a comment

Choose a reason for hiding this comment

pranavrth left a comment

Choose a reason for hiding this comment