Feature/bugfix 1616 #1630
Merged
Feature/bugfix 1616 #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pranavrth
requested changes
Oct 16, 2023
pranavrth
requested changes
Oct 17, 2023
mahajanadhitya
force-pushed
the
feature/bugfix-1616
branch
from
08d155c to
ed16fc4
Compare
to describe all the users, keeps previous behavior for a list
|
Made some change following what we were talking about, keeping same behavior if a list is passed |
pranavrth
requested changes
Oct 25, 2023
pranavrth
requested changes
Oct 25, 2023
| @@ -869,10 +869,14 @@ def test_describe_user_scram_credentials_api(): | |||
| # Describe User Scram API | |||
| a = AdminClient({"socket.timeout.ms": 10}) | |||
|
|
|||
| f = a.describe_user_scram_credentials() | |||
There was a problem hiding this comment.
Add an integration test for the fix that we are deploying i.e. describe all users case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1616