Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added topic id to describe group response #1645

Merged
merged 39 commits into from
Oct 23, 2023
Merged

Added topic id to describe group response #1645

merged 39 commits into from
Oct 23, 2023

Conversation

pranavrth
Copy link
Member

No description provided.

emasab
emasab reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about Python C API

src/confluent_kafka/admin/_topic.py Show resolved Hide resolved
src/confluent_kafka/__init__.py Show resolved Hide resolved
src/confluent_kafka/src/confluent_kafka.c Outdated Show resolved Hide resolved
src/confluent_kafka/src/confluent_kafka.c Outdated Show resolved Hide resolved
src/confluent_kafka/src/confluent_kafka.c Outdated Show resolved Hide resolved
src/confluent_kafka/src/confluent_kafka.c Outdated Show resolved Hide resolved
src/confluent_kafka/src/confluent_kafka.c Show resolved Hide resolved
@pranavrth pranavrth force-pushed the dev_add-topic-id-to-describe-topic-response branch from ee597e9 to 51361d3 Compare October 19, 2023 09:15
@pranavrth pranavrth marked this pull request as ready for review October 19, 2023 09:15
@pranavrth pranavrth requested a review from a team as a code owner October 19, 2023 09:15
jainruchir and others added 25 commits October 20, 2023 13:16
@jainruchir @pranavrth
initial commit for describeCG API
1b05ff2
@jainruchir @pranavrth
initial commit for describeCG API(2)
20a0a9b
@jainruchir @pranavrth
DescribeTopics implemented
e3609d6
@jainruchir @pranavrth
Implemented Describe Topic and Describe Cluster with some tests
7fdf428
@jainruchir @pranavrth
Autopep fixes
2944772
@pranavrth
Compiling after all the changes related to changes in Request and Res…
80e1aa3 
…ponse
@pranavrth
Working after refactoring
4bc60c1
@pranavrth
Added integration tests
efa705d
@pranavrth
Updated integration tests to use generic assert
ecf9036
@pranavrth
Added more generalization
2487e33
@pranavrth
Refactoring
a1cc0bd
@pranavrth
Removed moved admin tests
1bfe3cb
@pranavrth
Some doc updates
a4a81c3
@pranavrth
Refactoring and some doc changes
4417027
@pranavrth
Some more Refactoring
6833620
@pranavrth
Handled null controller case
95d798c
@pranavrth
Updated the fixure to use conf
c17c228
@pranavrth
Added more tests for describe APIs
d56aea8
@pranavrth
Added rack information in the Node
c883bb6
@pranavrth
Introduced TopicCollection in describe_topics API
5467e51
@pranavrth
Updated In Sync replica field name to isr for TopicPartitionInfo
5791d91
@pranavrth
Changed TopicDescription topic field to name
9f1f45d
@pranavrth
PR comments
082aadb
@pranavrth
Handling cluster_id Null case
a025c0f
@pranavrth
PR comments and CHANGELOG added
2fbf2de
@pranavrth
Removed unwanted changes
b776eda
@pranavrth
PR comments addressed
6d087a7 
Added new classes to documentation
Added old classes to documentation which were not present
Fixed multiple issues with doc rendering
@pranavrth
Fixed styling issue
3aab626
@pranavrth
Updated Changelog to reflect Rack info as well
52d0946
@pranavrth pranavrth force-pushed the dev_add-topic-id-to-describe-topic-response branch from c17e915 to 7b4b588 Compare October 20, 2023 07:51
Base automatically changed from dev_kip430_rebase to master October 23, 2023 09:29
emasab
emasab approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pranavrth pranavrth merged commit a945782 into master Oct 23, 2023
1 check passed
@pranavrth pranavrth deleted the dev_add-topic-id-to-describe-topic-response branch October 23, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emasab emasab emasab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavrth @emasab @jainruchir