Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DGS-10484 Improve SR caching on Python client #1744

Merged
merged 3 commits into from
May 13, 2024
Merged

DGS-10484 Improve SR caching on Python client #1744

merged 3 commits into from
May 13, 2024

Conversation

kcorman0
Copy link
Member

@kcorman0 kcorman0 commented May 8, 2024 •
edited
Loading

Adding to some SR calls which lack caching but could benefit from it

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented May 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented May 8, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kcorman0 kcorman0 marked this pull request as ready for review May 9, 2024 17:33
@kcorman0 kcorman0 requested a review from a team as a code owner May 9, 2024 17:33
rayokota
rayokota approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kcorman0 , LGTM

emasab
emasab approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kcorman0 kcorman0 merged commit 7905ccb into master May 13, 2024
3 checks passed
@kcorman0 kcorman0 deleted the kipp/more-caching branch May 13, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emasab emasab emasab approved these changes

@rayokota rayokota rayokota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kcorman0 @rayokota @emasab