KIP 848:Extend DescribeConfigs and IncrementalAlterConfigs to support GROUP Config #1856
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
PratRanj07
changed the title
airlock-confluentinc
bot
force-pushed
the
dev_test_support_grp
branch
from
bd9120d to
b88b020
Compare
airlock-confluentinc
bot
force-pushed
the
dev_test_support_grp
branch
from
658c698 to
e709ce7
Compare
pranavrth
requested changes
Apr 16, 2025
There was a problem hiding this comment.
Add CONFIG_SOURCE_GROUP_CONFIG to admin/_init.py as well to expose in confluent_kafka.admin module.
airlock-confluentinc
bot
force-pushed
the
dev_test_support_grp
branch
2 times, most recently
from
704c33b to
61ddbe5
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
airlock-confluentinc
bot
force-pushed
the
dev_test_support_grp
branch
from
ec32ad3 to
ab0ebab
Compare
This comment has been minimized.
This comment has been minimized.
airlock-confluentinc
bot
force-pushed
the
dev_test_support_grp
branch
from
ab0ebab to
7c1cf51
Compare
This comment has been minimized.
This comment has been minimized.
airlock-confluentinc
bot
force-pushed
the
dev_test_support_grp
branch
from
7c1cf51 to
a9c0566
Compare
This comment has been minimized.
This comment has been minimized.
emasab
reviewed
Apr 17, 2025
| @@ -147,3 +149,34 @@ def test_incremental_alter_configs(kafka_cluster): | |||
|
|
|||
| # Assert expected config entries. | |||
| assert_expected_config_entries(fs, 1, expected) | |||
|
|
|||
| if TestUtils.use_group_protocol_consumer(): | |||
There was a problem hiding this comment.
Suggested change
| if TestUtils.use_group_protocol_consumer(): | |
| # TODO: enable this test for the classic run too, when | |
| # Confluent Platform test cluster is upgraded to 8.0.0 | |
| if TestUtils.use_group_protocol_consumer(): |
emasab
approved these changes
Apr 17, 2025
Analysis Details1 Issue
Coverage and Duplications
Project ID: confluent-kafka-python |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to add support for Group Resource type for IncrementalAlterConfigs API as specified in KIP 848 and extended the DescribeConfigs support till API version 3.
Additional changed the integration test to check for Group Resource Type.
Librdkafka PR: #4939