Skip to content

Conversation

rayokota
Copy link
Member

@rayokota rayokota commented May 5, 2025

What

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@Copilot Copilot AI review requested due to automatic review settings May 5, 2025 18:37
@rayokota rayokota requested review from a team as code owners May 5, 2025 18:37
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a potential None reference issue in the CSFLE executor by ensuring that self.config is always set to a dictionary.

  • Adds a branch to initialize self.config to an empty dictionary if rule_conf is not provided and self.config is None.
  • Helps prevent runtime errors when accessing self.config.

@sonarqube-confluent

This comment has been minimized.

@rayokota rayokota changed the title Fix None ref in CSFLE executor Fix possible NPE in CSFLE executor May 6, 2025
@sonarqube-confluent
Copy link

Passed

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage 100.00% Coverage (60.90% Estimated after merge)
  • Duplications No duplication information (1.00% Estimated after merge)

Project ID: confluent-kafka-python

View in SonarQube

@rayokota rayokota changed the title Fix possible NPE in CSFLE executor DGS-20678 Fix possible NPE in CSFLE executor May 6, 2025
@rayokota rayokota merged commit cc2656c into master May 6, 2025
3 checks passed
@rayokota rayokota deleted the fix-npe branch May 6, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants