-
Notifications
You must be signed in to change notification settings - Fork 935
DGS-22404 Add AppRole auth for HC Vault #2084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds AppRole authentication support to the HashiCorp Vault KMS driver, allowing authentication using role ID and secret ID as an alternative to token-based authentication.
- Added support for AppRole authentication configuration through new constants and environment variables
- Extended the KMS client constructor to handle role ID and secret ID parameters
- Implemented AppRole login functionality in the client initialization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
hcvault_driver.py | Added AppRole configuration constants and environment variable fallback logic |
hcvault_client.py | Extended constructor to accept AppRole credentials and perform AppRole login |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/confluent_kafka/schema_registry/rules/encryption/hcvault/hcvault_client.py
Show resolved
Hide resolved
src/confluent_kafka/schema_registry/rules/encryption/hcvault/hcvault_client.py
Show resolved
Hide resolved
src/confluent_kafka/schema_registry/rules/encryption/hcvault/hcvault_client.py
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
076fee9
to
0c535d5
Compare
0c535d5
to
c607c8d
Compare
What
Add AppRole auth for HC Vault. Tested manually with local HC Vault instance with AppRole auth enabled.
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups