Py3: use bytes for Message payload and key #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,40 +1,94 @@ | |||
| Confluent's Apache Kafka client for Python | |||
| ========================================== | |||
|
|
|||
| Confluent's Kafka client for Python wraps the librdkafka C library, providing | |||
| full Kafka protocol support at great performance and reliability. | |||
There was a problem hiding this comment.
support at great -> support with great
|
@edenhill LGTM. I only managed to test the integration test in python3. Trying to run the tests in a py3 virtualenv was running some completely different set of tests that I have no idea where they came from. What's your process for doing testing under both py2 and py3? |
|
So far I've manually switched between two virtualenvs (2.7 and 3.5) and then doing: |
|
ok, i must have just screwed something up when setting up the py3 virtualenv |
Closed
ghost
mentioned this pull request
7 tasks
dtheodor
pushed a commit
to dtheodor/confluent-kafka-python
that referenced
this pull request
Sep 4, 2018
dtheodor
pushed a commit
to dtheodor/confluent-kafka-python
that referenced
this pull request
Sep 4, 2018
6 tasks
7 tasks
7 tasks
adityakishore
pushed a commit
to mapr/confluent-kafka-python
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.