Added logging parameter for Avro(Consumer|Producer). #699
Conversation
|
It looks like @venthur hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
|
[clabot:check] |
|
@confluentinc It looks like @venthur just signed our Contributor License Agreement. 👍 Always at your service, clabot |
|
Any updates on this one? |
|
@rnpridgeon suggests a workaround here. That being said, it looks like this PR might be ready for review @rnpridgeon? |
| while f.cnt == 0: | ||
| kc.poll(timeout=0.5) | ||
|
|
||
| print('%s: %d log messages seen' % (f.name, f.cnt)) |
There was a problem hiding this comment.
should add a check that the logger actually saw some logs
There was a problem hiding this comment.
isn't that implied by the f.cnt > 0 after the while loop?
The patch introduces **kwargs and just passes them to the underlying super calls. Tests are included. Closes: confluentinc#698
venthur
force-pushed
the
fix/logging_for_avro
branch
from
406ab96 to
cfb9794
Compare
|
Thank you for this! |
|
I've rebased this branch against current master. I think the failing tests are unrelated to this merge request. |
The patch introduces **kwargs and just passes them to the underlying
super calls.
Tests are included.
Closes: #698