Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change schema registry to work without avro #950

Closed
wants to merge 1 commit into from

Conversation

jaysonsantos
Copy link
Contributor

These errors are being used just to export avro's exceptions but this means that you can never use schema-registry if you installed confluent kafka with confluent-kafka[schema-registry]

@ghost
Copy link

ghost commented Sep 15, 2020

It looks like @jaysonsantos hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@jaysonsantos
Copy link
Contributor Author

[clabot:check]
it would be nice if you guys used https for the cla page

@ghost
Copy link

ghost commented Sep 16, 2020

@confluentinc It looks like @jaysonsantos just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@edenhill edenhill added the serdes Avro, JSON, Protobof, Schema-registry label Mar 9, 2021
Copy link
Contributor

@mhowlett mhowlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this is bad. solution is not ideal, but resolves the problem and we can back it out without consequence if we want, eventually doing something better.

@mhowlett
Copy link
Contributor

for some reason which i don't understand this is showing a conflict, and not allowing this to be resolved here, so I opened again in #1055 and merged that.

@mhowlett mhowlett closed this Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
serdes Avro, JSON, Protobof, Schema-registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants