This repository has been archived by the owner on Feb 20, 2024. It is now read-only.
Add affinity customization
#492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For charts that have existing `affinity` hard-coded configs defined, add support for overriding the hard-coded values. For charts that lack `affinity` config entirely, add the support for injecting custom affinity values.
|
@confluentinc It looks like @kppullin just signed our Contributor License Agreement. 👍 Always at your service, clabot |
kppullin
commented
Jan 28, 2021
| @@ -61,6 +61,10 @@ nodeSelector: {} | |||
| ## Ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/ | |||
| tolerations: [] | |||
|
|
|||
| ## Pod scheduling constraints | |||
| ## Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity | |||
| affinity: {} | |||
There was a problem hiding this comment.
Note that the cp-control-center's deployment template already includes logic to conditionally use the Values.affinity config, however the affinity block is missing from this values.yaml file.
gAmUssA
approved these changes
Feb 1, 2021
|
Thank you @kppullin |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For charts that have existing
affinityhard-coded configsdefined, add support for overriding the hard-coded values.
For charts that lack
affinityconfig entirely, addsupport for injecting custom affinity values.
How was this patch tested?
Tested locally using
helm template:helm template <CHART>helm template <CHART> --set affinity=testdiff <(helm template <CHART>) <(helm template <CHART> --set affinity=test)