Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to distroless/java11-debian11 as base OS #127

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Migrate to distroless/java11-debian11 as base OS #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions distribution/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# under the License.
#

ARG JDK_VERSION=8
ARG JDK_VERSION=11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this argument is just the default. I think it's ok to change it, but the actual value for the argument actually gets defined via https://github.com/confluentinc/druid/blob/24.0.2-confluent/distribution/pom.xml#L46

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, upstream it was also updated to 11 as the default in the dockerfile as well so figured we should here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version we run still defaults to 8 https://github.com/apache/druid/blob/druid-24.0.2/distribution/docker/Dockerfile#L20, but since distroless doesn't have 8 anymore changing it here makes sense.

FROM alpine as extractor

ARG VERSION=
Expand All @@ -30,7 +30,7 @@ RUN tar -zxf /src/apache-druid-${VERSION}-bin.tar.gz -C /opt \

FROM amd64/busybox:1.30.0-glibc as busybox

FROM gcr.io/distroless/java:$JDK_VERSION
FROM gcr.io/distroless/java$JDK_VERSION-debian11
LABEL maintainer="Apache Druid Developers <dev@druid.apache.org>"

COPY --from=busybox /bin/busybox /busybox/busybox
Expand Down