[OBSDATA-3156] Apply Confluent Patches on top of Druid 28.0.1 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension packaging included both shaded and unshaded dependencies in the classpath. Shading should not be necessary in this case. Also excludes guava dependencies, which are already provided by Druid and don't need to be added to the extensions jars.
* METRICS-1302: Added prefix support for resource labels. * Addressed review comments. * Added and moved configs to ingestion spec, optimized code. * Addressed review comments * Updated metric dimesnion and other review comments * Flipped ternary operator * Moved from NullHandling to StringUtils. * Removed unnecessary HashMap. * Removed verbosity for instance variables.
* Added getters for configs, labels for distribution metric. * Addressed review comments * Removed extra brackets in JsonProperty.
Align protobuf dependencies to use the main pom one
- fix millisecond resolution being dropped when converting timestamps - remove unnecessary conversion of ByteBuffer to ByteString - make test code a little more concise
- remove the need to parse timestamps into their own column - reduce the number of times we copy maps of labels - pre-size hashmaps and arrays when possible - use loops instead of streams in critical sections Combined these changes improve parsing performance by about 15% - added benchmark for reference
…tFormat (#26) InputRowParsers have been deprecated in favor or InputFormat. This implements the InputFormat version of the OpenCensus Protobuf parser, and deprecates the existing InputRowParser implementation. - the existing InputRowParser behavior is unchanged. - the InputFormat behaves like the InputRowParser, except for the default resource prefix which now defaults to "resource." instead of empty. - both implementations internally delegate to OpenCensusProtobufReader, which is covered by the existing InputRowParser tests.
xvrl
reviewed
Dec 7, 2023
xvrl
reviewed
Dec 7, 2023
pagrawal10
changed the base branch from
28.0.0-confluent
to
28.0.1-confluent
pagrawal10
changed the title
extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitter.java
Show resolved
Hide resolved
...ons-contrib/kafka-emitter/src/test/java/org/apache/druid/emitter/kafka/KafkaEmitterTest.java
Show resolved
Hide resolved
...re/s3-extensions/src/main/java/org/apache/druid/storage/s3/ServerSideEncryptingAmazonS3.java
Show resolved
Hide resolved
| @@ -29,6 +30,8 @@ | |||
| public interface RowFunction | |||
| { | |||
| Object eval(Row row); | |||
|
|
|||
| List<String> evalDimension(Row row); | |||
| default List<String> evalDimension(Row row) | |||
There was a problem hiding this comment.
Add a test. And push the test upstream
There was a problem hiding this comment.
I think it would be cleaner to add the test for this upstream and once that PR is merged, cherry-pick it in a separate PR. Otherwise, there might be some changes suggested in the test and would require me to keep updating it in both places.
There was a problem hiding this comment.
Please create the test upstream then
karthikgurram87
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply Confluent patches on top of Druid 28.0.1 https://confluentinc.atlassian.net/wiki/spaces/OBSERVE/pages/1506182651/Druid+Patches
Druid 28 release notes can be found here
Description
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
Release note
For tips about how to write a good release note, see Release notes.
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: