Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting Scripted Upsert #760

Open
wants to merge 2 commits into
base: 11.1.x
Choose a base branch
from

Conversation

NicholasDCole
Copy link

@NicholasDCole NicholasDCole commented Mar 11, 2024

Add scripted upsert functionality to ES Sink Connector

Problem

Need scripted upsert functionality to support older Elastic Search client/server version

Also, need ability to inject Kafka payload as Params object

Solution

Add SCRIPTED_UPSERT write.method and custom logic in DataConverter.java to handle parameter injection as well as script injection into ES UpdateRequest

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

Merge -> 11.1.x -> Create release

This is a Backport for 11.1.x . I will also merge to master within another PR

N/A

Copy link

cla-assistant bot commented Mar 11, 2024

CLA assistant check
All committers have signed the CLA.

@NicholasDCole NicholasDCole marked this pull request as ready for review March 13, 2024 13:14
@NicholasDCole NicholasDCole requested a review from a team as a code owner March 13, 2024 13:14
@NicholasDCole
Copy link
Author

Please review @sp-gupta @kkonstantine @snehashisp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant