Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support N topics written under the same directory #544 #553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JozoVilcek
Copy link

Problem

When using a custom partitioner, one can opt out from having topic data separated into topic specific directory. But when writing data from N topics under the same directory, the recovery of offsets is looking for files under paths which does not exists.

Solution

Detect if partitioner us adding topic name to the output path. If not, exclude it from the search path for committed files -> start search from parent directory. This however does not cover generic case when partitioner chooses some exotic path strategy.

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@JozoVilcek JozoVilcek requested a review from a team as a code owner March 17, 2021 12:09
@ghost
Copy link

ghost commented Mar 17, 2021

It looks like @JozoVilcek hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@JozoVilcek
Copy link
Author

[clabot:check]

@ghost
Copy link

ghost commented Mar 17, 2021

@confluentinc It looks like @JozoVilcek just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@JozoVilcek
Copy link
Author

Does this PR make sense? Any kind of feedback is much appreciated

@JozoVilcek
Copy link
Author

@kpatelatwork I did find you active in other MRs. Can you help me how can I bring contributions into the attention of code owners? I have problem to get feedback on this and few other old MRs

@JozoVilcek JozoVilcek changed the title Support N topics written under the same directory Support N topics written under the same directory #544 Jun 1, 2023
@JozoVilcek
Copy link
Author

@janjwerner-confluent , @rishabhbits038 could you please review this request and let me know the feedback if this has a chance to get in. If yes I would work on updating the PR and make it green

@cla-assistant
Copy link

cla-assistant bot commented Aug 27, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant