Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide feature file event provider #678

Draft
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

parisni
Copy link

@parisni parisni commented Sep 4, 2023

Problem

Solution

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

parisni added 24 commits July 11, 2023 15:31
Squashed commit of the following:

commit 509d64acbd22b6e73473dc7614fa19ec9a9f1c30
Author: Guillaume SANON <guillaume.sanon@adevinta.com>
Date:   Tue Jul 11 15:12:41 2023 +0200

    Use MinioContainer as replacement of real S3

commit b780ff4a26673c837708aa869ac65cd63d222362
Author: Guillaume SANON <guillaume.sanon@adevinta.com>
Date:   Tue Jul 11 15:11:47 2023 +0200

    Create Minio Container to simulate S3

commit 2fa0547e3c7e2e59db914c281824205deb7c723b
Author: Guillaume SANON <guillaume.sanon@adevinta.com>
Date:   Tue Jul 11 15:11:23 2023 +0200

    Update testcontainers lib
also use abstract class for constructor spec
@parisni parisni requested a review from a team as a code owner September 4, 2023 12:09
@cla-assistant
Copy link

cla-assistant bot commented Sep 4, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Guillaume SANON
❌ parisni


Guillaume SANON seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@parisni parisni marked this pull request as draft September 4, 2023 12:18
@parisni parisni changed the title File event Provide feature file event provider Sep 4, 2023
@parisni parisni force-pushed the feat/partition-file-callback branch from f95eb98 to a2894c0 Compare September 11, 2023 16:15
@parisni parisni force-pushed the feat/partition-file-callback branch from a2894c0 to d22dc90 Compare September 12, 2023 09:43
previously the record count could be wrong and reflect how much data the
worker was writting, independantly of the partition
@parisni parisni force-pushed the feat/partition-file-callback branch from 4cd799a to 1fd0c65 Compare February 12, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant