-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide feature file event provider #678
Draft
parisni
wants to merge
35
commits into
confluentinc:master
Choose a base branch
from
leboncoin:feat/partition-file-callback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Provide feature file event provider #678
parisni
wants to merge
35
commits into
confluentinc:master
from
leboncoin:feat/partition-file-callback
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following: commit 509d64acbd22b6e73473dc7614fa19ec9a9f1c30 Author: Guillaume SANON <guillaume.sanon@adevinta.com> Date: Tue Jul 11 15:12:41 2023 +0200 Use MinioContainer as replacement of real S3 commit b780ff4a26673c837708aa869ac65cd63d222362 Author: Guillaume SANON <guillaume.sanon@adevinta.com> Date: Tue Jul 11 15:11:47 2023 +0200 Create Minio Container to simulate S3 commit 2fa0547e3c7e2e59db914c281824205deb7c723b Author: Guillaume SANON <guillaume.sanon@adevinta.com> Date: Tue Jul 11 15:11:23 2023 +0200 Update testcontainers lib
also use abstract class for constructor spec
This reverts commit 48da579.
Guillaume SANON seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
parisni
force-pushed
the
feat/partition-file-callback
branch
from
September 11, 2023 16:15
f95eb98
to
a2894c0
Compare
parisni
force-pushed
the
feat/partition-file-callback
branch
from
September 12, 2023 09:43
a2894c0
to
d22dc90
Compare
previously the record count could be wrong and reflect how much data the worker was writting, independantly of the partition
parisni
force-pushed
the
feat/partition-file-callback
branch
from
February 12, 2024 10:05
4cd799a
to
1fd0c65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing done:
Release Plan