Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timezone test fixes for local setup #10629

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

hrishabhg
Copy link
Member

Description

In local, the timezone tests fail for format like X. X formats the timezone diff. If the timezone difference is 0530, X return 05 , XX return 0530. Hence, it is required that the timezone tests take care of that.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

@hrishabhg hrishabhg requested a review from a team as a code owner January 3, 2025 07:24
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@hrishabhg hrishabhg merged commit 8b7b7a8 into master Jan 22, 2025
2 of 5 checks passed
@hrishabhg hrishabhg deleted the fix-timezone-test-local branch January 22, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants