Skip to content

Fixing SunsetAirFlightData reference and test #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixing SunsetAirFlightData reference and test #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa834b9
Fixing SunsetAirFlightData reference and test
DavidGonzalezPineiro May 15, 2025
f993d26
Trigger CLA check
DavidGonzalezPineiro May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions solutions/16-merging-streams/src/main/java/flightimporter/FlightImporterJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public static void main(String[] args) throws Exception {
.setValueOnlyDeserializer(new JsonDeserializationSchema(SkyOneAirlinesFlightData.class))
.build();

KafkaSource<SunsetAirFlightData> sunsetSource = KafkaSource.<SkyOneAirlinesFlightData>builder()
KafkaSource<SunsetAirFlightData> sunsetSource = KafkaSource.<SunsetAirFlightData>builder()
.setProperties(consumerConfig)
.setTopics("sunset")
.setStartingOffsets(OffsetsInitializer.latest())
Expand Down Expand Up @@ -87,4 +87,4 @@ public static DataStream<FlightData> defineWorkflow(DataStream<SkyOneAirlinesFli

return skyOneFlightStream.union(sunsetFlightStream);
}
}
}
19 changes: 16 additions & 3 deletions staging/16-merging-streams/src/test/java/models/SunsetAirFlightDataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
import static org.apache.flink.types.PojoTestUtils.assertSerializedAsPojo;
import static org.junit.jupiter.api.Assertions.*;

import java.time.ZoneId;
import java.time.ZonedDateTime;

class SunsetAirFlightDataTest {

ObjectMapper mapper = new ObjectMapper().registerModule(new JavaTimeModule());
Expand Down Expand Up @@ -93,10 +96,20 @@ public void serializer_shouldSerializeAndDeserializeTheCorrectObject() throws Ex

@Test
public void serializer_shouldHandleUnknownFields() throws Exception {
String json = "{\"emailAddress\":\"LJNZGYPIER@email.com\",\"flightDepartureTime\":\"2023-10-16T22:25:00.000Z\",\"iataDepartureCode\":\"LAS\",\"flightArrivalTime\":\"2023-10-17T09:38:00.000Z\",\"iataArrivalCode\":\"BOS\",\"flightNumber\":\"SKY1522\",\"confirmation\":\"SKY1OUJUUK\",\"unknownField\":\"ignore\"}";

String json = "{\"customerEmailAddress\":\"LJNZGYPIER@email.com\",\"departureTime\":\"2023-10-16T22:25:00.000Z\",\"departureAirport\":\"LAS\",\"arrivalTime\":\"2023-10-17T09:38:00.000Z\",\"arrivalAirport\":\"BOS\",\"flightId\":\"SKY1522\",\"referenceNumber\":\"SKY1OUJUUK\",\"unknownField\":\"ignore\"}";
SunsetAirFlightData object = mapper.readValue(json, SunsetAirFlightData.class);

SunsetAirFlightData expected = new SunsetAirFlightData();
expected.setCustomerEmailAddress("LJNZGYPIER@email.com");
expected.setDepartureTime(ZonedDateTime.parse("2023-10-16T22:25:00.000Z").withZoneSameInstant(ZoneId.of("UTC")));
expected.setDepartureAirport("LAS");
expected.setArrivalTime(ZonedDateTime.parse("2023-10-17T09:38:00.000Z").withZoneSameInstant(ZoneId.of("UTC")));
expected.setArrivalAirport("BOS");
expected.setFlightId("SKY1522");
expected.setReferenceNumber("SKY1OUJUUK");

assertInstanceOf(SunsetAirFlightData.class, object);
assertEquals(expected, object);
}
}
}