Skip to content

Commit

Permalink
style fix
Browse files Browse the repository at this point in the history
  • Loading branch information
PratRanj07 committed Oct 7, 2024
1 parent 2960d89 commit b49e0db
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 26 deletions.
24 changes: 11 additions & 13 deletions examples/elect_leaders.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,21 +129,19 @@ print_elect_leaders_result(const rd_kafka_ElectLeaders_result_t *result) {

results = rd_kafka_ElectLeadersResult_partitions(res, &results_cnt);
for (i = 0; i < results_cnt; i++) {
const rd_kafka_topic_partition_t *partition = rd_kafka_topic_partition_result_partition(results[i]);
const rd_kafka_error_t *err = rd_kafka_topic_partition_result_error(results[i]);
const rd_kafka_topic_partition_t *partition =
rd_kafka_topic_partition_result_partition(results[i]);
const rd_kafka_error_t *err =
rd_kafka_topic_partition_result_error(results[i]);
if (rd_kafka_error_code(err)) {
printf(
"%% ElectLeaders failed for %s [%" PRId32
"] : %s\n",
partition->topic,
partition->partition,
rd_kafka_error_string(err));
printf("%% ElectLeaders failed for %s [%" PRId32
"] : %s\n",
partition->topic, partition->partition,
rd_kafka_error_string(err));
} else {
printf(
"%% ElectLeaders succeeded for %s [%" PRId32
"]\n",
partition->topic,
partition->partition);
printf("%% ElectLeaders succeeded for %s [%" PRId32
"]\n",
partition->topic, partition->partition);
}
}

Expand Down
10 changes: 6 additions & 4 deletions src/rdkafka.h
Original file line number Diff line number Diff line change
Expand Up @@ -6964,17 +6964,19 @@ rd_kafka_group_result_partitions(const rd_kafka_group_result_t *groupres);

/**
* @brief Topic Partition Result provides per-topic+partition operation result
*
* Consists of TopicPartition object and error object.
*/

/**
* @returns the topic partition object from the topic partition result object.
* @remarks lifetime of the returned string is the same as the \p
* partition_result.
* The error object is set inside the topic partition object. For the
* detailed error information, use rd_kafka_topic_partition_result_error()
* The error object is set inside the topic partition object. For the
* detailed error information, use
* rd_kafka_topic_partition_result_error()
*/
RD_EXPORT const rd_kafka_topic_partition_t *rd_kafka_topic_partition_result_partition(
RD_EXPORT const rd_kafka_topic_partition_t *
rd_kafka_topic_partition_result_partition(
const rd_kafka_topic_partition_result_t *partition_result);

/**
Expand Down
6 changes: 4 additions & 2 deletions src/rdkafka_admin.c
Original file line number Diff line number Diff line change
Expand Up @@ -9237,8 +9237,10 @@ rd_kafka_ElectLeadersResponse_parse(rd_kafka_op_t *rko_req,
}

if (top_level_error_code) {
rd_kafka_admin_result_fail(rko_req, top_level_error_code,
"ElectLeaders request failed: %s", rd_kafka_err2str(top_level_error_code));
rd_kafka_admin_result_fail(
rko_req, top_level_error_code,
"ElectLeaders request failed: %s",
rd_kafka_err2str(top_level_error_code));
return top_level_error_code;
}

Expand Down
15 changes: 8 additions & 7 deletions src/rdkafka_aux.c
Original file line number Diff line number Diff line change
Expand Up @@ -345,8 +345,9 @@ rd_kafka_topic_partition_result_new(const char *topic,

rd_kafka_topic_partition_result_t *new_result;

new_result = rd_calloc(1, sizeof(*new_result));
new_result->topic_partition = rd_kafka_topic_partition_new(topic, partition);
new_result = rd_calloc(1, sizeof(*new_result));
new_result->topic_partition =
rd_kafka_topic_partition_new(topic, partition);
new_result->topic_partition->err = err;
new_result->error = rd_kafka_error_new(err, "%s", errstr);

Expand All @@ -369,7 +370,8 @@ const rd_kafka_error_t *rd_kafka_topic_partition_result_error(
void rd_kafka_topic_partition_result_destroy(
rd_kafka_topic_partition_result_t *partition_result) {
if (partition_result->topic_partition)
rd_kafka_topic_partition_destroy(partition_result->topic_partition);
rd_kafka_topic_partition_destroy(
partition_result->topic_partition);
if (partition_result->error)
rd_kafka_error_destroy(partition_result->error);
rd_free(partition_result);
Expand All @@ -389,10 +391,9 @@ void rd_kafka_topic_partition_result_destroy_array(

rd_kafka_topic_partition_result_t *rd_kafka_topic_partition_result_copy(
const rd_kafka_topic_partition_result_t *src) {
return rd_kafka_topic_partition_result_new(src->topic_partition->topic,
src->topic_partition->partition,
src->topic_partition->err,
src->error->errstr);
return rd_kafka_topic_partition_result_new(
src->topic_partition->topic, src->topic_partition->partition,
src->topic_partition->err, src->error->errstr);
}

void *rd_kafka_topic_partition_result_copy_opaque(const void *src,
Expand Down

0 comments on commit b49e0db

Please sign in to comment.