-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't call kinit cmd from rd_kafka_new() #3340
Conversation
504bf43
to
f0d5bb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me! Since I'm not very familiar with the code yet, I will let Matt to give the final approval.
@@ -4526,6 +4526,8 @@ ut_create_msgs (rd_kafka_msgq_t *rkmq, uint64_t msgid, int cnt) { | |||
|
|||
rkm = ut_rd_kafka_msg_new(0); | |||
rkm->rkm_u.producer.msgid = msgid++; | |||
rkm->rkm_ts_enq = rd_clock(); | |||
rkm->rkm_ts_timeout = rkm->rkm_ts_enq + (900 * 1000 * 1000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hard coded constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, it's a unit test
I think the broker wakeups might also fix #2912