Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues related to store_offset and next_offset during Barrier op in consume batch API #4208

Merged
merged 17 commits into from
Mar 22, 2023

Conversation

pranavrth
Copy link
Member

  1. Fixes app_offset and store_offset getting updated after reading each messages. This would have resulted in incorrect app_offset and store_offset in case of Barrier op purging some messages.
  2. Fixes pause and resume skipping some offsets in case of Barrier op due to the above app_offset update.

Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's remember to add a CHANGELOG entry, I've added a TODO.

@emasab emasab merged commit 5139719 into master Mar 22, 2023
@emasab emasab deleted the dev_fix_batch_consumer_app_store_offset branch March 22, 2023 14:58
emasab pushed a commit that referenced this pull request Mar 22, 2023
… in consume batch API (#4208)

these offsets were set before the batch was completed, making it possible to commit
offsets that had not been received by the application, or to skip messages after a resume
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants