Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed no-module configuration option from libcrypto source build #4234

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Removed no-module configuration option from libcrypto source build #4234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfccdb5
Removed no-module configuration option from libcrypto source build
pranavrth Mar 27, 2023
8e43cbf
PR comment
pranavrth Mar 29, 2023
fde2695
PR comment
pranavrth Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ librdkafka v2.1.0 is a feature release:

## Fixes

### OpenSSL fixes

* Fixed OpenSSL static build not able to use external modules like FIPS
provider module.

### Consumer fixes

* A reference count issue was blocking the consumer from closing.
Expand Down
6 changes: 1 addition & 5 deletions mklove/modules/configure.libssl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,7 @@ function libcrypto_install_source {
conf_args="${conf_args} no-krb5"
fi

if [[ $ver == 3.* ]]; then
# Make sure legacy provider (et.al) are built-in, since we're building
# a static library we don't want to rely on dynamically loaded modules.
conf_args="${conf_args} no-module"
else
if [[ $ver != 3.* ]]; then
# OpenSSL 3 deprecates ENGINE support, but we still need it, so only
# add no-deprecated to non-3.x builds.
conf_args="${conf_args} no-deprecated"
Expand Down