Uuid support in mock cluster #4591
Conversation
emasab
force-pushed
the
dev_mock_cluster_topic_id_support
branch
from
25b5960 to
4fa605c
Compare
| for (i = 0; i < 16; i += 2) { | ||
| uint16_t rand_uint16 = (uint16_t)rd_jitter(0, INT16_MAX - 1); | ||
| /* No need to convert endianess here because it's still only | ||
| * a random value. */ | ||
| rand_values_app = (unsigned char *)&rand_uint16; | ||
| rand_values_bytes[i] |= rand_values_app[0]; | ||
| rand_values_bytes[i + 1] |= rand_values_app[1]; | ||
| } | ||
|
|
||
| rand_values_bytes[6] &= 0x0f; /* clear version */ | ||
| rand_values_bytes[6] |= 0x40; /* version 4 */ | ||
| rand_values_bytes[8] &= 0x3f; /* clear variant */ | ||
| rand_values_bytes[8] |= 0x80; /* IETF variant */ |
There was a problem hiding this comment.
I think we should move this to rdrand.h
There was a problem hiding this comment.
It generates a Uuid, all the code for a Uuid is here
There was a problem hiding this comment.
Maybe I can move it to a rdkafka_uuid.h and rdkafka_uuid.c
There was a problem hiding this comment.
I was talking about the generic part related to random bytes generation here.
There was a problem hiding this comment.
Regarding rdkafka_uuid.h and rdkafka_uuid.c, we can have them but don't do it for now. Let's do it later when we we won't have much conflicts with other ongoing dev work.
There was a problem hiding this comment.
I think we should move this to rdrand.h
here the random value is generated in rd_jitter that is already in rdrand.h the rest is code related to Uuid
src/rdkafka_int.h
Outdated
| RD_EXPORT rd_kafka_Uuid_t *rd_kafka_Uuid_random(); | ||
|
|
||
| RD_EXPORT const char *rd_kafka_Uuid_str(const rd_kafka_Uuid_t *uuid); |
There was a problem hiding this comment.
These can be in proto.h and the definitions should be in proto.c as everything internal related to Uuid is present there.
src/rdkafka.c
Outdated
| * | ||
| * @remark Must be freed after use using rd_kafka_Uuid_destroy(). | ||
| */ | ||
| rd_kafka_Uuid_t *rd_kafka_Uuid_random() { |
There was a problem hiding this comment.
Why are we returning a pointer instead of a value here?
There was a problem hiding this comment.
Yeah, better to return the struct, its usage is internal only
| for (i = 0; i < 16; i += 2) { | ||
| uint16_t rand_uint16 = (uint16_t)rd_jitter(0, INT16_MAX - 1); | ||
| /* No need to convert endianess here because it's still only | ||
| * a random value. */ | ||
| rand_values_app = (unsigned char *)&rand_uint16; | ||
| rand_values_bytes[i] |= rand_values_app[0]; | ||
| rand_values_bytes[i + 1] |= rand_values_app[1]; | ||
| } | ||
|
|
||
| rand_values_bytes[6] &= 0x0f; /* clear version */ | ||
| rand_values_bytes[6] |= 0x40; /* version 4 */ | ||
| rand_values_bytes[8] &= 0x3f; /* clear variant */ | ||
| rand_values_bytes[8] |= 0x80; /* IETF variant */ |
There was a problem hiding this comment.
I was talking about the generic part related to random bytes generation here.
| * | ||
| * @remark Must be freed after use using rd_kafka_Uuid_destroy(). | ||
| */ | ||
| rd_kafka_Uuid_t rd_kafka_Uuid_random() { |
There was a problem hiding this comment.
Move this to rdkafka_proto.h where all the other internal functions related to Uuid are present
There was a problem hiding this comment.
that is just a header we cannot move all the implementation there, we can refactor to its own file
| * | ||
| * @remark Must be freed after use. | ||
| */ | ||
| const char *rd_kafka_Uuid_str(const rd_kafka_Uuid_t *uuid) { |
There was a problem hiding this comment.
Move this to rdkafka_proto.h where all the other internal functions related to Uuid are present
| for (i = 0; i < 16; i += 2) { | ||
| uint16_t rand_uint16 = (uint16_t)rd_jitter(0, INT16_MAX - 1); | ||
| /* No need to convert endianess here because it's still only | ||
| * a random value. */ | ||
| rand_values_app = (unsigned char *)&rand_uint16; | ||
| rand_values_bytes[i] |= rand_values_app[0]; | ||
| rand_values_bytes[i + 1] |= rand_values_app[1]; | ||
| } | ||
|
|
||
| rand_values_bytes[6] &= 0x0f; /* clear version */ | ||
| rand_values_bytes[6] |= 0x40; /* version 4 */ | ||
| rand_values_bytes[8] &= 0x3f; /* clear variant */ | ||
| rand_values_bytes[8] |= 0x80; /* IETF variant */ |
There was a problem hiding this comment.
Regarding rdkafka_uuid.h and rdkafka_uuid.c, we can have them but don't do it for now. Let's do it later when we we won't have much conflicts with other ongoing dev work.
emasab
force-pushed
the
dev_mock_cluster_topic_id_support
branch
from
0011cf9 to
b5fe084
Compare
emasab
force-pushed
the
dev_mock_cluster_topic_id_support
branch
from
b5fe084 to
69c0311
Compare
also adds the possibility to generate pseudo-random Uuids
No description provided.