Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata cache by topic id #4676

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Metadata cache by topic id #4676

merged 4 commits into from
Apr 11, 2024

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Apr 8, 2024

and improved documentation of Metadata functions

src/rdkafka_request.c Outdated Show resolved Hide resolved
src/rdkafka_request.c Outdated Show resolved Hide resolved
src/rdkafka_request.c Outdated Show resolved Hide resolved
src/rdkafka_request.c Show resolved Hide resolved
src/rdkafka_request.c Show resolved Hide resolved
src/rdkafka_metadata.h Outdated Show resolved Hide resolved
src/rdkafka_metadata_cache.c Show resolved Hide resolved
src/rdkafka_metadata_cache.c Show resolved Hide resolved
if (old)
/* Insert (and replace existing) entry into the AVL tree sorted
* by topic id. */
if (!RD_KAFKA_UUID_IS_ZERO(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check this whole logic again. This is tricky and might have some issues.

src/rdkafka_metadata_cache.c Outdated Show resolved Hide resolved
@emasab emasab force-pushed the dev_metadata_cache_topic_id branch from 4d7eab9 to 8ea3b9e Compare April 11, 2024 09:17
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few minor comments.

src/rdkafka_request.c Show resolved Hide resolved
src/rdkafka_metadata_cache.c Outdated Show resolved Hide resolved
src/rdkafka_metadata_cache.c Show resolved Hide resolved
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!.. Nice changes!

@emasab emasab merged commit f2e88a9 into dev_kip848 Apr 11, 2024
2 checks passed
@emasab emasab deleted the dev_metadata_cache_topic_id branch April 11, 2024 15:12
emasab added a commit that referenced this pull request Apr 15, 2024
improve documentation of Metadata functions
emasab added a commit that referenced this pull request Apr 18, 2024
improve documentation of Metadata functions
anchitj pushed a commit that referenced this pull request Jun 10, 2024
improve documentation of Metadata functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants