Client certificate chain is now sent #4894
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
airlock-confluentinc
bot
force-pushed
the
dev_ssl_send_full_certificate_chain
branch
from
c77c7e4 to
ec21967
Compare
emasab
changed the base branch from
master
to
dev_kip848_mock_handler_and_integration_tests
airlock-confluentinc
bot
force-pushed
the
dev_ssl_send_full_certificate_chain
branch
from
ec21967 to
7ec52aa
Compare
…PEM format. Test that CA with untrusted chain fails authentication.
airlock-confluentinc
bot
force-pushed
the
dev_ssl_send_full_certificate_chain
branch
from
6cf59f0 to
d64f4f8
Compare
milindl
reviewed
Dec 6, 2024
| if (sk_X509_num(ca) > 0) | ||
| cert->chain = ca; | ||
| else | ||
| sk_X509_pop_free(cert->chain, |
There was a problem hiding this comment.
Doesn't this need to be sk_X509_pop_free(ca, instead? because cert->chain isn't assigned to yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using
ssl.certificate.pemorssl_certificateorssl.keystore.location.Without that, broker must explicitly add any intermediate certification
authority certificate to its truststore to be able to accept client
certificate.
Happens since: 1.x