Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client cert callback to check if trusted certificate authorities match with client certificate chain #4900

Open
wants to merge 3 commits into
base: dev_ssl_send_full_certificate_chain
Choose a base branch
from

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Nov 13, 2024

in Java this selection is happening in X509KeyManagerImpl.getAliases

The field that is checked is certificate_authorities extension in TLS 1.3, that was present in CertificateRequest in previous versions in TLS and SSL.

@emasab emasab requested a review from a team as a code owner November 13, 2024 15:48
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_ssl_check_certificate_authorites_extension branch 3 times, most recently from 9bfa41c to a81b168 Compare November 13, 2024 15:56
Copy link
Member

@trnguyencflt trnguyencflt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change

@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_ssl_check_certificate_authorites_extension branch from a81b168 to 7d147c1 Compare December 4, 2024 19:54
@emasab emasab changed the base branch from master to dev_ssl_send_full_certificate_chain December 4, 2024 19:55
@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_ssl_check_certificate_authorites_extension branch from 7d147c1 to 7f71403 Compare December 4, 2024 20:01
@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_ssl_send_full_certificate_chain branch from ec21967 to 7ec52aa Compare December 4, 2024 20:03
@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_ssl_check_certificate_authorites_extension branch from 7f71403 to 4eaab30 Compare December 5, 2024 12:34
@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_ssl_send_full_certificate_chain branch from 6cf59f0 to d64f4f8 Compare December 5, 2024 17:28
emasab and others added 3 commits December 5, 2024 18:28
when no certificate is sent instead or the one
received when it's sent but not trusted.
…h with client certificate chain.

Co-authored-by: trnguyencflt <trnguyen@confluent.io>
@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_ssl_check_certificate_authorites_extension branch from 4eaab30 to 1266043 Compare December 5, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants