[tests] Fix for a warning about using the variable in input and output #5013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a warning about using the same variable for both input and output by refactoring how the debug string is built.
- Introduces an index variable to track the current position in the output buffer
- Adds an extra bound check in the while loop to avoid buffer overruns
Comments suppressed due to low confidence (1)
tests/test.c:1108
- [nitpick] Consider renaming 'i' to a more descriptive name, such as 'current_pos', to improve code readability.
size_t i = rd_snprintf(debug_with_contexts, sizeof(debug_with_contexts), "%s", test_debug ? test_debug : "");
pranavrth
reviewed
Apr 3, 2025
tests/test.c
Outdated
| test_debug ? test_debug : ""); | ||
| /* Add all debug contexts and set debug configuration */ | ||
| while (*debug_contexts) { | ||
| while (*debug_contexts && i < sizeof(debug_with_contexts) - 2) { |
Member
There was a problem hiding this comment.
Suggested change
| while (*debug_contexts && i < sizeof(debug_with_contexts) - 2) { | |
| while (strlen(*debug_contexts) + i <= sizeof(debug_with_contexts) - 2) { |
emasab
changed the title
Contributor
Author
|
Closing as it was merged in #5059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.