Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements/DI module #398

Merged
merged 7 commits into from
Sep 2, 2022
Merged

Conversation

astubbs
Copy link
Contributor

@astubbs astubbs commented Aug 24, 2022

Dependency injection, needed for sane testing of transactions.

Abiding by the zero dependencies policy - just needed something simple.

  • Changelog

@astubbs astubbs self-assigned this Aug 24, 2022
@astubbs astubbs requested a review from rkolesnev August 25, 2022 09:45
@astubbs astubbs marked this pull request as ready for review August 25, 2022 09:51
Copy link
Contributor Author

@astubbs astubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rkolesnev rkolesnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - couple of questions - added as comments

@astubbs astubbs changed the title Improvements/di module Improvements/DI module Sep 2, 2022
@astubbs astubbs merged commit f8bab66 into confluentinc:master Sep 2, 2022
@astubbs astubbs deleted the improvements/di-module branch September 2, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants