refactor: SortedSet's all the way down (Set->SortedSet) #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astubbs
force-pushed
the
fixes/set-to-sortedset
branch
from
708cbe1 to
c6c5f73
Compare
astubbs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two natures of SortedSet are used - contains() for fast lookup, and potential traversal in order (which there isn't atm). This change ensures that any potential traversals will always occur in Offset order. Otherwise, simply Set has no traversal order guarantees - which has been an issue in the past.
Checklist
Blocked by: