-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #327: Improve error message when Kafka Streams magic number found #482
fixes #327: Improve error message when Kafka Streams magic number found #482
Conversation
f0dd4f4
to
33140bf
Compare
33140bf
to
02d9efe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
We only need one exception - if that's the pattern to use
can you include a reference for where you got the magic number info from? byte 1 and 2
if this is the error that's printed:
"Kafka Streams offset metadata V1 not supported"
we need something more friendly. should be something like "it looks like you're reusing a kafka streams consumer group id with PC. This isn't supported - you should use a fresh consumer group, unique to your use of pc" - something like that?
54923fa
to
d3a25b6
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just about there! can close this one up quick now.
...rc/test/java/io/confluent/parallelconsumer/offsets/WorkManagerOffsetMapCodecManagerTest.java
Show resolved
Hide resolved
...rc/test/java/io/confluent/parallelconsumer/offsets/WorkManagerOffsetMapCodecManagerTest.java
Show resolved
Hide resolved
parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/offsets/OffsetEncoding.java
Outdated
Show resolved
Hide resolved
parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/offsets/OffsetEncoding.java
Outdated
Show resolved
Hide resolved
...rc/test/java/io/confluent/parallelconsumer/offsets/WorkManagerOffsetMapCodecManagerTest.java
Outdated
Show resolved
Hide resolved
...lel-consumer-core/src/main/java/io/confluent/parallelconsumer/offsets/EncodedOffsetPair.java
Outdated
Show resolved
Hide resolved
…umer/offsets/OffsetEncoding.java Co-authored-by: Antony Stubbs <antony.stubbs@gmail.com>
…umer/offsets/WorkManagerOffsetMapCodecManagerTest.java Co-authored-by: Antony Stubbs <antony.stubbs@gmail.com>
…umer/offsets/OffsetEncoding.java Co-authored-by: Antony Stubbs <antony.stubbs@gmail.com>
…umer/offsets/EncodedOffsetPair.java Co-authored-by: Antony Stubbs <antony.stubbs@gmail.com>
@astubbs Thanks for the review! I will apply the suggested feedback today so we can close this 😊 |
…el-consumer into bugs/fix-magic-number-ks
Fixes: #327
Checklist