Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: After new performance fix PR#530 merges - corner case could cause out of order processing #534

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

astubbs
Copy link
Contributor

@astubbs astubbs commented Dec 29, 2022

Under unrealistically high load with no-op processing, broker poller unblocking a partition could cause ProcessingShard to skip forward in its entries and take work out of order.
Was discovered when fixing a synthetic high performance benchmark, after an O(n) algo was fixed to O(1), creating the state for the race condition to appear. Probably could not happen without the fix, as it's related to the performance of certain parts of the system.
This sort of issue won't be possible once the new IPC system is merged and Thread contracts established.

Related:

Checklist

  • Changelog

Under unrealistically high load with no-op processing, broker poller unblocking a partition could cause ProcessingShard to skip forward in its entries and take work out of order.
Was discovered when fixing a synthetic high performance benchmark, after an O(n) algo was fixed to O(1), creating the state for the race condition to appear. Probably could not happen without the fix, as it's related to the performance of certain parts of the system.
@astubbs astubbs marked this pull request as ready for review December 29, 2022 15:09
@astubbs astubbs changed the title fix: Corner case could cause out of order processing for KEY mode fix: Corner case could cause out of order processing, with new performance fixes Dec 29, 2022
@astubbs astubbs changed the title fix: Corner case could cause out of order processing, with new performance fixes fix: Corner case could cause out of order processing, after new performance fixe merged Jan 4, 2023
@astubbs astubbs changed the title fix: Corner case could cause out of order processing, after new performance fixe merged fix: Corner case could cause out of order processing, after new performance fix merged Jan 25, 2023
@astubbs astubbs changed the title fix: Corner case could cause out of order processing, after new performance fix merged fix: After new performance fix PR#530 merges - corner case could cause out of order processing Jan 25, 2023
@astubbs astubbs merged commit 754e29f into master Jan 25, 2023
@astubbs astubbs deleted the fixes/unblock-race branch January 25, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant